From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Sat, 22 Jun 2013 15:01:40 +0000 (-0600)
Subject: Marked one spot where newly allocated Store::get*() entries are forgotten and
X-Git-Tag: SQUID_3_5_0_1~444^2~55
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=635a85d4b880284d271e0dd10f9ef9e014016100;p=thirdparty%2Fsquid.git

Marked one spot where newly allocated Store::get*() entries are forgotten and
probably leaking.
---

diff --git a/src/client_side_reply.cc b/src/client_side_reply.cc
index 2bf9a17437..e56d5e9f90 100644
--- a/src/client_side_reply.cc
+++ b/src/client_side_reply.cc
@@ -872,7 +872,7 @@ clientReplyContext::purgeFoundObject(StoreEntry *entry)
         ErrorState *err = clientBuildError(ERR_ACCESS_DENIED, Http::scForbidden, NULL,
                                            http->getConn()->clientConnection->remote, http->request);
         startError(err);
-        return;
+        return; // XXX: leaking unused entry is some store does not keep it
     }
 
     StoreIOBuffer localTempBuffer;