From: Stefan Eissing Date: Tue, 25 Jul 2023 15:14:21 +0000 (+0200) Subject: http2: disable asssertion blocking OSSFuzz testing X-Git-Tag: curl-8_3_0~290 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=63936d9ff83950d583a9588e35ecc04cffb43f76;p=thirdparty%2Fcurl.git http2: disable asssertion blocking OSSFuzz testing - not clear how this triggers and it blocks OSSFuzz testing other things. Since we handle the case with an error return, disabling the assertion for now seems the best way forward. Fixes #11500 Closes #11519 --- diff --git a/lib/http2.c b/lib/http2.c index 6c09ec1a1f..0956e510c8 100644 --- a/lib/http2.c +++ b/lib/http2.c @@ -2077,7 +2077,9 @@ static ssize_t cf_h2_send(struct Curl_cfilter *cf, struct Curl_easy *data, else if(stream->upload_blocked_len) { /* the data in `buf` has alread been submitted or added to the * buffers, but have been EAGAINed on the last invocation. */ - DEBUGASSERT(len >= stream->upload_blocked_len); + /* TODO: this assertion triggers in OSSFuzz runs and it is not + * clear why. Disable for now to let OSSFuzz continue its tests. + DEBUGASSERT(len >= stream->upload_blocked_len); */ if(len < stream->upload_blocked_len) { /* Did we get called again with a smaller `len`? This should not * happend. We are not prepared to handle that. */