From: Amos Jeffries <yadij@users.noreply.github.com>
Date: Wed, 2 Mar 2022 06:02:32 +0000 (+0000)
Subject: Drop redundant LIBADD_DL overwrite (#989)
X-Git-Tag: SQUID_6_0_1~226
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=63a76d3f68cd904951dc07d230b84f3047b01521;p=thirdparty%2Fsquid.git

Drop redundant LIBADD_DL overwrite (#989)

The removed code questions whether it is needed.

The answer is no. LIBADD_DL is already set by one of the LT_INIT
macros to the same value we are overwriting it to.

Except, in the case where the user has supplied a custom libdl
location this code broke their build.
---

diff --git a/configure.ac b/configure.ac
index dda2102a3f..ed80a0ed81 100644
--- a/configure.ac
+++ b/configure.ac
@@ -218,13 +218,6 @@ LT_LIB_DLLOAD
 AC_SUBST(INCLTDL)
 AC_SUBST(LIBLTDL)
 
-if test "x$enable_loadable_modules" = "xyes";
-then
-  # Why is this needed? Should not LT_INIT (or LT_LIB_DLLOAD) from libtool do that?
-  LIBADD_DL=${lt_cv_dlopen_libs}
-  AC_SUBST([LIBADD_DL])
-fi
-
 SQUID_CC_GUESS_VARIANT
 SQUID_CC_GUESS_OPTIONS