From: Salah Triki <salah.triki@gmail.com>
Date: Sun, 27 Apr 2025 09:57:45 +0000 (+0100)
Subject: wireless: purelifi: plfxlc: fix memory leak in plfxlc_usb_wreq_asyn()
X-Git-Tag: v6.16-rc1~132^2~46^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=63a9a727d373fa5b8ce509eef50dbc45e0f745b9;p=thirdparty%2Flinux.git

wireless: purelifi: plfxlc: fix memory leak in plfxlc_usb_wreq_asyn()

Add usb_free_urb() in the error path to prevent memory leak.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
Link: https://patch.msgid.link/aA3_maPlEJzO7wrL@pc
[fix subject]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---

diff --git a/drivers/net/wireless/purelifi/plfxlc/usb.c b/drivers/net/wireless/purelifi/plfxlc/usb.c
index 10d2e2124ff81..c2a1234b59db6 100644
--- a/drivers/net/wireless/purelifi/plfxlc/usb.c
+++ b/drivers/net/wireless/purelifi/plfxlc/usb.c
@@ -503,8 +503,10 @@ int plfxlc_usb_wreq_async(struct plfxlc_usb *usb, const u8 *buffer,
 			  (void *)buffer, buffer_len, complete_fn, context);
 
 	r = usb_submit_urb(urb, GFP_ATOMIC);
-	if (r)
+	if (r) {
+		usb_free_urb(urb);
 		dev_err(&udev->dev, "Async write submit failed (%d)\n", r);
+	}
 
 	return r;
 }