From: Christof Schmitt Date: Tue, 7 Jul 2020 05:27:59 +0000 (-0700) Subject: vfs_posixacl: Remove unnecessary call to acl_set_permset X-Git-Tag: talloc-2.3.2~1075 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=63b9b2a103a6762e18d0bf0f820f42bd85a8bdcc;p=thirdparty%2Fsamba.git vfs_posixacl: Remove unnecessary call to acl_set_permset After the initial acl_get_permset, the permset is alreadying pointing to the ACL entry and all changes are done on the ACL entry. There is no need to overwrite the permissions in the ACL entry again with the same value in the acl_set_permset call. Signed-off-by: Christof Schmitt Reviewed-by: Andreas Schneider Autobuild-User(master): Christof Schmitt Autobuild-Date(master): Fri Jul 17 18:33:41 UTC 2020 on sn-devel-184 --- diff --git a/source3/modules/vfs_posixacl.c b/source3/modules/vfs_posixacl.c index 83fb0455b3a..80115ebc6df 100644 --- a/source3/modules/vfs_posixacl.c +++ b/source3/modules/vfs_posixacl.c @@ -274,7 +274,8 @@ static int smb_acl_set_mode(acl_entry_t entry, SMB_ACL_PERM_T perm) ((ret = acl_add_perm(permset, ACL_EXECUTE)) != 0)) { return ret; } - return acl_set_permset(entry, permset); + + return 0; } static acl_t smb_acl_to_posix(const struct smb_acl_t *acl)