From: Amos Jeffries <squid3@treenet.co.nz>
Date: Wed, 10 Feb 2010 22:29:49 +0000 (+1300)
Subject: Author: Kieran Whitbread <k.j.whitbread@qmul.ac.uk>
X-Git-Tag: SQUID_3_2_0_1~425
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6412f46c1315f999621c9c52e674fd32f3b73bf7;p=thirdparty%2Fsquid.git

Author: Kieran Whitbread <k.j.whitbread@qmul.ac.uk>
Bug 2858: Segment violation in HTCP
---

diff --git a/src/htcp.cc b/src/htcp.cc
index 96a42281b3..8d7d08c68f 100644
--- a/src/htcp.cc
+++ b/src/htcp.cc
@@ -1270,6 +1270,13 @@ htcpHandleClr(htcpDataHeader * hdr, char *buf, int sz, IpAddress &from)
         return;
     }
 
+    if (NULL == s->request) {
+        debugs(31, 3, "htcpHandleClr: request not generated.");
+        htcpLogHtcp(from, hdr->opcode, LOG_UDP_INVALID, s->uri);
+        htcpFreeSpecifier(s);
+        return;
+    }
+
     if (!htcpAccessCheck(Config.accessList.htcp_clr, s, from)) {
         debugs(31, 2, "htcpHandleClr: Access denied");
         htcpLogHtcp(from, hdr->opcode, LOG_UDP_DENIED, s->uri);