From: Yauheni Kaliuta Date: Tue, 8 Jun 2021 06:29:22 +0000 (+0300) Subject: libkmod-module: check "new_from_name" return value in get_builtin X-Git-Tag: v30~36 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=64541d6aad210879e104e4796beeef49d4311f6d;p=thirdparty%2Fkmod.git libkmod-module: check "new_from_name" return value in get_builtin kmod_module_new_from_name() may fail and return error value. It is handled properly across the code, but in this particular place the check is missing. Signed-off-by: Yauheni Kaliuta --- diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c index b6320cc8..6e0ff1a9 100644 --- a/libkmod/libkmod-module.c +++ b/libkmod/libkmod-module.c @@ -2912,7 +2912,10 @@ int kmod_module_get_builtin(struct kmod_ctx *ctx, struct kmod_list **list) goto fail; } - kmod_module_new_from_name(ctx, modname, &mod); + err = kmod_module_new_from_name(ctx, modname, &mod); + if (err < 0) + goto fail; + kmod_module_set_builtin(mod, true); *list = kmod_list_append(*list, mod);