From: Arnd Bergmann Date: Thu, 8 May 2014 13:52:14 +0000 (+0200) Subject: usb: gadget: s3c2410_udc: don't use pr_debug return value X-Git-Tag: v3.16-rc1~30^2~34^2~171^2~22 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=64890edb8536618ee856fbca699fe930fcef1573;p=thirdparty%2Fkernel%2Flinux.git usb: gadget: s3c2410_udc: don't use pr_debug return value pr_debug() may be defined as "do { } while (0)" in some configurations, which means one cannot rely on the return value to be available. In the dprintk function in this driver, we can work around the resulting build error trivially by returning the length that this function already knows and ignoring the return value of pr_debug. Signed-off-by: Arnd Bergmann Cc: Ben Dooks Cc: Kukjin Kim Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index dd9678f85c586..7987aa049fab2 100644 --- a/drivers/usb/gadget/s3c2410_udc.c +++ b/drivers/usb/gadget/s3c2410_udc.c @@ -117,7 +117,8 @@ static int dprintk(int level, const char *fmt, ...) sizeof(printk_buf)-len, fmt, args); va_end(args); - return pr_debug("%s", printk_buf); + pr_debug("%s", printk_buf); + return len; } #else static int dprintk(int level, const char *fmt, ...)