From: Markus Elfring Date: Wed, 9 Aug 2017 07:30:34 +0000 (+0200) Subject: ALSA: emux: Delete two error messages for a failed memory allocation in snd_emux_crea... X-Git-Tag: v4.14-rc1~114^2~7^2~135 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=64a591e67e30599bed0179f187e034cc0828010e;p=thirdparty%2Fkernel%2Flinux.git ALSA: emux: Delete two error messages for a failed memory allocation in snd_emux_create_port() Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c index fd6cbd439511d..396c406d0f779 100644 --- a/sound/synth/emux/emux_seq.c +++ b/sound/synth/emux/emux_seq.c @@ -145,14 +145,12 @@ snd_emux_create_port(struct snd_emux *emu, char *name, /* Allocate structures for this channel */ p = kzalloc(sizeof(*p), GFP_KERNEL); - if (!p) { - snd_printk(KERN_ERR "no memory\n"); + if (!p) return NULL; - } + p->chset.channels = kcalloc(max_channels, sizeof(*p->chset.channels), GFP_KERNEL); if (!p->chset.channels) { - snd_printk(KERN_ERR "no memory\n"); kfree(p); return NULL; }