From: Gord Thompson <gord@gordthompson.com>
Date: Sat, 22 Feb 2020 13:44:05 +0000 (-0700)
Subject: Implement autocommit isolation level for pysqlite
X-Git-Tag: rel_1_4_0b1~443^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=64e8303debd8064d7d9c01c3300cca5f54c02db1;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Implement autocommit isolation level for pysqlite

Fixes: #5164
Change-Id: I190b9de552dfed9f2a33babf82e42465ef09c82a
---

diff --git a/.gitignore b/.gitignore
index 48b5ecd4be..f6b44391d9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -37,3 +37,4 @@ test/test_schema.db
 /.vscode/
 /.ipynb_checkpoints/
 *.ipynb
+/querytest.db
diff --git a/doc/build/changelog/unreleased_13/5164.rst b/doc/build/changelog/unreleased_13/5164.rst
new file mode 100644
index 0000000000..5883ecb1dd
--- /dev/null
+++ b/doc/build/changelog/unreleased_13/5164.rst
@@ -0,0 +1,5 @@
+.. change::
+    :tags: sqlite, usecase
+    :tickets: 5164
+
+    Implemented AUTOCOMMIT isolation level for SQLite when using pysqlite.
diff --git a/lib/sqlalchemy/dialects/sqlite/base.py b/lib/sqlalchemy/dialects/sqlite/base.py
index a63ce0033f..c79357176b 100644
--- a/lib/sqlalchemy/dialects/sqlite/base.py
+++ b/lib/sqlalchemy/dialects/sqlite/base.py
@@ -168,8 +168,8 @@ work when using the pysqlite driver.
 
 .. _sqlite_isolation_level:
 
-Transaction Isolation Level
-----------------------------
+Transaction Isolation Level / Autocommit
+----------------------------------------
 
 SQLite supports "transaction isolation" in a non-standard way, along two
 axes.  One is that of the
@@ -185,6 +185,15 @@ and ``"READ UNCOMMITTED"`` corresponding to a value of 0 and 1, respectively.
 SQLite defaults to ``SERIALIZABLE``, however its behavior is impacted by
 the pysqlite driver's default behavior.
 
+When using the pysqlite driver, the ``"AUTOCOMMIT"`` isolation level is also
+available, which will alter the pysqlite connection using the ``.isolation_level``
+attribute on the DBAPI connection and set it to None for the duration
+of the setting.
+
+.. versionadded:: 1.3.16 added support for SQLite AUTOCOMMIT isolation level
+   when using the pysqlite / sqlite3 SQLite driver.
+
+
 The other axis along which SQLite's transactional locking is impacted is
 via the nature of the ``BEGIN`` statement used.   The three varieties
 are "deferred", "immediate", and "exclusive", as described at
diff --git a/lib/sqlalchemy/dialects/sqlite/pysqlite.py b/lib/sqlalchemy/dialects/sqlite/pysqlite.py
index b8a42a5062..807f9488d1 100644
--- a/lib/sqlalchemy/dialects/sqlite/pysqlite.py
+++ b/lib/sqlalchemy/dialects/sqlite/pysqlite.py
@@ -324,6 +324,12 @@ ourselves. This is achieved using two event listeners::
         # emit our own BEGIN
         conn.exec_driver_sql("BEGIN")
 
+.. warning:: When using the above recipe, it is advised to not use the
+   :paramref:`.execution_options.isolation_level` setting on
+   :class:`.Connection` and :func:`.create_engine` with the SQLite driver,
+   as this function necessarily will also alter the ".isolation_level" setting.
+
+
 Above, we intercept a new pysqlite connection and disable any transactional
 integration.   Then, at the point at which SQLAlchemy knows that transaction
 scope is to begin, we emit ``"BEGIN"`` ourselves.
@@ -437,6 +443,20 @@ class SQLiteDialect_pysqlite(SQLiteDialect):
     def _get_server_version_info(self, connection):
         return self.dbapi.sqlite_version_info
 
+    def set_isolation_level(self, connection, level):
+        if hasattr(connection, "connection"):
+            dbapi_connection = connection.connection
+        else:
+            dbapi_connection = connection
+
+        if level == "AUTOCOMMIT":
+            dbapi_connection.isolation_level = None
+        else:
+            dbapi_connection.isolation_level = ""
+            return super(SQLiteDialect_pysqlite, self).set_isolation_level(
+                connection, level
+            )
+
     def create_connect_args(self, url):
         if url.username or url.password or url.host or url.port:
             raise exc.ArgumentError(
diff --git a/test/requirements.py b/test/requirements.py
index e9fb6a3054..d9fcd698c3 100644
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -381,6 +381,7 @@ class DefaultRequirements(SuiteRequirements):
 
         if against(config, "sqlite"):
             default = "SERIALIZABLE"
+            levels.add("AUTOCOMMIT")
         elif against(config, "postgresql"):
             default = "READ COMMITTED"
             levels.add("AUTOCOMMIT")