From: Hans Zhang <18255117159@163.com> Date: Thu, 22 May 2025 16:15:33 +0000 (+0800) Subject: PCI/ASPM: Consolidate variable declaration and initialization X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=64fd90ef25206b1b9f232fb192ceadb814e991a4;p=thirdparty%2Fkernel%2Flinux.git PCI/ASPM: Consolidate variable declaration and initialization Merge the declaration and initialization of 'val' into a single statement for clarity. This eliminates a redundant assignment operation and improves code readability while maintaining the same functionality. Signed-off-by: Hans Zhang <18255117159@163.com> Signed-off-by: Manivannan Sadhasivam Signed-off-by: Bjorn Helgaas Link: https://patch.msgid.link/20250522161533.394689-1-18255117159@163.com --- diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index 98b3022802b2..919a05b97647 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -884,10 +884,9 @@ static void pcie_aspm_cap_init(struct pcie_link_state *link, int blacklist) /* Configure the ASPM L1 substates. Caller must disable L1 first. */ static void pcie_config_aspm_l1ss(struct pcie_link_state *link, u32 state) { - u32 val; + u32 val = 0; struct pci_dev *child = link->downstream, *parent = link->pdev; - val = 0; if (state & PCIE_LINK_STATE_L1_1) val |= PCI_L1SS_CTL1_ASPM_L1_1; if (state & PCIE_LINK_STATE_L1_2)