From: Garri Djavadyan <garryd@comnet.uz>
Date: Sun, 27 Nov 2016 13:57:50 +0000 (+1300)
Subject: Bug 3290: authenticate_ttl not working for digest authentication
X-Git-Tag: M-staged-PR71~358
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=65cbd5a711e14ca07da2e096b24bfb14161ec20c;p=thirdparty%2Fsquid.git

Bug 3290: authenticate_ttl not working for digest authentication
---

diff --git a/src/auth/digest/Config.cc b/src/auth/digest/Config.cc
index bf6dddbcee..0ad3a408f7 100644
--- a/src/auth/digest/Config.cc
+++ b/src/auth/digest/Config.cc
@@ -1064,6 +1064,10 @@ Auth::Digest::Config::decode(char const *proxy_auth, const char *aRequestRealm)
          * the user agent won't change user name without warning.
          */
         authDigestUserLinkNonce(digest_user, nonce);
+
+        /* auth_user is now linked, we reset these values
+         * after external auth occurs anyway */
+        auth_user->expiretime = current_time.tv_sec;
     } else {
         debugs(29, 9, "Found user '" << username << "' in the user cache as '" << auth_user << "'");
         digest_user = static_cast<Auth::Digest::User *>(auth_user.getRaw());
diff --git a/src/auth/digest/UserRequest.cc b/src/auth/digest/UserRequest.cc
index 77f3d0573d..3afebb4d4c 100644
--- a/src/auth/digest/UserRequest.cc
+++ b/src/auth/digest/UserRequest.cc
@@ -187,12 +187,7 @@ Auth::Digest::UserRequest::authenticate(HttpRequest * request, ConnStateData *,
     auth_user->credentials(Auth::Ok);
 
     /* password was checked and did match */
-    debugs(29, 4, HERE << "user '" << auth_user->username() << "' validated OK");
-
-    /* auth_user is now linked, we reset these values
-     * after external auth occurs anyway */
-    auth_user->expiretime = current_time.tv_sec;
-    return;
+    debugs(29, 4, "user '" << auth_user->username() << "' validated OK");
 }
 
 Auth::Direction