From: Andrey Shinkevich Date: Wed, 29 May 2019 18:20:27 +0000 (+0300) Subject: hw/block/fdc: floppy command FIFO memory initialization X-Git-Tag: v4.1.0-rc0~52^2~11 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6653d1318d623681fc7e849e9ae5069ad144864a;p=thirdparty%2Fqemu.git hw/block/fdc: floppy command FIFO memory initialization The uninitialized memory allocated for the command FIFO of the floppy controller during the VM hardware initialization incurs many unwanted reports by Valgrind when VM state is being saved. That verbosity hardens a search for the real memory issues when the iotests run. Particularly, the patch eliminates 20 unnecessary reports of the Valgrind tool in the iotest #169. Signed-off-by: Andrey Shinkevich Message-id: 1559154027-282547-1-git-send-email-andrey.shinkevich@virtuozzo.com Reviewed-by: John Snow Signed-off-by: Max Reitz --- diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a64378f84bb..77af9979de1 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2648,6 +2648,7 @@ static void fdctrl_realize_common(DeviceState *dev, FDCtrl *fdctrl, FLOPPY_DPRINTF("init controller\n"); fdctrl->fifo = qemu_memalign(512, FD_SECTOR_LEN); + memset(fdctrl->fifo, 0, FD_SECTOR_LEN); fdctrl->fifo_size = 512; fdctrl->result_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, fdctrl_result_timer, fdctrl);