From: Michael Paquier Date: Mon, 28 Feb 2022 01:53:56 +0000 (+0900) Subject: pg_stat_statements: Remove unnecessary call to GetUserId() X-Git-Tag: REL_15_BETA1~618 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=667726fbe50f21d7d3ce5d5c5949a45c2496b60f;p=thirdparty%2Fpostgresql.git pg_stat_statements: Remove unnecessary call to GetUserId() The same is done a couple of lines above, so there is no need for the same, extra, call. Author: Dong Wook Lee Reviewed-by: Julien Rouhaud Discussion: https://postgr.es/m/CAAcBya+szDd1Y6dJU4_dbH_Ye3=G=8O1oQGG01kv3Tpie7wELQ@mail.gmail.com --- diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index 38d92a89cc4..d803253ceaf 100644 --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statements/pg_stat_statements.c @@ -1508,7 +1508,7 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo, pgssEntry *entry; /* Superusers or members of pg_read_all_stats members are allowed */ - is_allowed_role = is_member_of_role(GetUserId(), ROLE_PG_READ_ALL_STATS); + is_allowed_role = is_member_of_role(userid, ROLE_PG_READ_ALL_STATS); /* hash table must exist already */ if (!pgss || !pgss_hash)