From: Michael Haggerty Date: Sat, 25 May 2013 09:08:22 +0000 (+0200) Subject: exclude_existing(): set existing_refs.strdup_strings X-Git-Tag: v1.8.4-rc0~170^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=66ce0366285f73c340f04a21b3d8be898d7bf5a7;p=thirdparty%2Fgit.git exclude_existing(): set existing_refs.strdup_strings The each_ref_fn add_existing() adds refnames to the existing_refs list. But the lifetimes of these refnames is not guaranteed by the refs API, so configure the string_list to make copies as it adds them. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano --- diff --git a/builtin/show-ref.c b/builtin/show-ref.c index 8d9b76a02f..4a0310da37 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -103,7 +103,7 @@ static int add_existing(const char *refname, const unsigned char *sha1, int flag */ static int exclude_existing(const char *match) { - static struct string_list existing_refs = STRING_LIST_INIT_NODUP; + static struct string_list existing_refs = STRING_LIST_INIT_DUP; char buf[1024]; int matchlen = match ? strlen(match) : 0;