From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 20 Sep 2025 15:40:17 +0000 (+0200)
Subject: tftp: return error when sendto() fails
X-Git-Tag: rc-8_17_0-2~425
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=66d6075af9c9bb5e4ef7985c7bc46942c9d4ae99;p=thirdparty%2Fcurl.git

tftp: return error when sendto() fails

The code just called failf() and then continued without returning error.

Reported in Joshua's sarif data

Closes #18643
---

diff --git a/lib/tftp.c b/lib/tftp.c
index 7dc06261b2..8b6246a342 100644
--- a/lib/tftp.c
+++ b/lib/tftp.c
@@ -535,11 +535,12 @@ static CURLcode tftp_send_first(struct tftp_conn *state,
                       (SEND_TYPE_ARG3)sbytes, 0,
                       CURL_SENDTO_ARG5(&remote_addr->curl_sa_addr),
                       (curl_socklen_t)remote_addr->addrlen);
+    free(filename);
     if(senddata != (ssize_t)sbytes) {
       char buffer[STRERROR_LEN];
       failf(data, "%s", Curl_strerror(SOCKERRNO, buffer, sizeof(buffer)));
+      return CURLE_SEND_ERROR;
     }
-    free(filename);
     break;
 
   case TFTP_EVENT_OACK: