From: Arne Schwabe Date: Mon, 22 May 2023 09:12:31 +0000 (+0200) Subject: Print a more user-friendly error when tls-crypt-v2 client auth fails X-Git-Tag: v2.6.6~15 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=66f51e80b981f08ebc3c38f3fac7d0c88caeb85d;p=thirdparty%2Fopenvpn.git Print a more user-friendly error when tls-crypt-v2 client auth fails While it might be clear to people being (too?) well versed in typical crypto applications that an authentication failure probably mean wrong decryption key, this is not really obvious for the typical user/server admin. Change-Id: If0f0e7d53f915d39ab69aaaac43dc73bb9c26ae9 Signed-off-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20230522091231.2837468-1-arne@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26718.html Signed-off-by: Gert Doering (cherry picked from commit 7a477c16a7c2a7016c7b15ea98fe3c40e8ef675b) --- diff --git a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.c index 88b2d6d7c..73542368e 100644 --- a/src/openvpn/tls_crypt.c +++ b/src/openvpn/tls_crypt.c @@ -524,6 +524,8 @@ tls_crypt_v2_unwrap_client_key(struct key2 *client_key, struct buffer *metadata, dmsg(D_CRYPTO_DEBUG, "tag_check: %s", format_hex(tag_check, sizeof(tag_check), 0, &gc)); CRYPT_ERROR("client key authentication error"); + msg(D_TLS_DEBUG_LOW, "This might be a client-key that was generated for " + "a different tls-crypt-v2 server key)"); } if (buf_len(&plaintext) < sizeof(client_key->keys))