From: drh <>
Date: Tue, 22 Aug 2023 16:44:33 +0000 (+0000)
Subject: Fix a harmless memory leak in the sqldiff utility.
X-Git-Tag: version-3.43.0~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=675342a5a85082fa681c0dfb8fef94e6b9c0e50e;p=thirdparty%2Fsqlite.git

Fix a harmless memory leak in the sqldiff utility.

FossilOrigin-Name: 724bc15701f3f647c741b614d4ac4fd98e1cdfe49a85f48c64fb1df5b83811b0
---

diff --git a/manifest b/manifest
index 9e13232d15..ba974b14ca 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Add\smakefile\starget\s"sdevtest"\s-\slike\s"mdevtest"\sexcept\sasan\sand\susan\senabled\sfor\sthe\snon-debug\stest.
-D 2023-08-22T15:19:50.971
+C Fix\sa\sharmless\smemory\sleak\sin\sthe\ssqldiff\sutility.
+D 2023-08-22T16:44:33.916
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -2054,7 +2054,7 @@ F tool/speedtest8.c 2902c46588c40b55661e471d7a86e4dd71a18224
 F tool/speedtest8inst1.c 7ce07da76b5e745783e703a834417d725b7d45fd
 F tool/spellsift.tcl 52b4b04dc4333c7ab024f09d9d66ed6b6f7c6eb00b38497a09f338fa55d40618 x
 F tool/split-sqlite3c.tcl 5aa60643afca558bc732b1444ae81a522326f91e1dc5665b369c54f09e20de60
-F tool/sqldiff.c 2a693b4e7c1818c23f871f82f0c3fe67d80b67e3f087893089d33da29c1e387e
+F tool/sqldiff.c efe73c6706b0ead9b4e415c684e4abf439e5f405793ae6ba50796e0e4a030349
 F tool/sqlite3_analyzer.c.in f88615bf33098945e0a42f17733f472083d150b58bdaaa5555a7129d0a51621c
 F tool/sqltclsh.c.in 1bcc2e9da58fadf17b0bf6a50e68c1159e602ce057210b655d50bad5aaaef898
 F tool/sqltclsh.tcl 862f4cf1418df5e1315b5db3b5ebe88969e2a784525af5fbf9596592f14ed848
@@ -2092,8 +2092,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 055ae724ff34bd41a1d97180b90fce081861856ac67572a633d31f518c20aa1e
-R 344a2b48243af16d1d58146e802dfb7a
-U dan
-Z 0f828f6e2d7bc70d5e26c65d0a7cafbf
+P a449d650cd3dcd1baaeb3a3de2aaaac45594397e04f95fe637b0fe4ddb273404
+R 896bb56aaa8cab009ab24ccd5316010e
+U drh
+Z 11f96baae8cc54ac54f1d899caef0ae2
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index a832b11fe6..cdb8c1c8db 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-a449d650cd3dcd1baaeb3a3de2aaaac45594397e04f95fe637b0fe4ddb273404
\ No newline at end of file
+724bc15701f3f647c741b614d4ac4fd98e1cdfe49a85f48c64fb1df5b83811b0
\ No newline at end of file
diff --git a/tool/sqldiff.c b/tool/sqldiff.c
index 5477ff97f0..0d27ff89e7 100644
--- a/tool/sqldiff.c
+++ b/tool/sqldiff.c
@@ -596,7 +596,9 @@ static void diff_one_table(const char *zTab, FILE *out){
 
   /* Build the comparison query */
   for(n2=n; az2[n2]; n2++){
-    fprintf(out, "ALTER TABLE %s ADD COLUMN %s;\n", zId, safeId(az2[n2]));
+    char *zTab = safeId(az2[n2]);
+    fprintf(out, "ALTER TABLE %s ADD COLUMN %s;\n", zId, zTab);
+    sqlite3_free(zTab);
   }
   nQ = nPk2+1+2*(n2-nPk2);
   if( n2>nPk2 ){