From: Christopher Faulet <cfaulet@haproxy.com>
Date: Thu, 17 Oct 2024 09:46:07 +0000 (+0200)
Subject: BUG/MINOR: http-ana: Don't report a server abort if response payload is invalid
X-Git-Tag: v3.1-dev11~118
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6790067e79566b2ca5943e72200361c40001bde2;p=thirdparty%2Fhaproxy.git

BUG/MINOR: http-ana: Don't report a server abort if response payload is invalid

If a parsing error is reported by the mux on the response payload, a proxy
error (PRXCOND) must be reported instead of a server abort (SRVCL). Because
of this bug, inavlid response may are reported as "SD--" or "SL--" in logs
instead of "PD--" or "PL--".

This patch must be backported to all stable versions.
---

diff --git a/src/http_ana.c b/src/http_ana.c
index cc7fc70005..a30100ffd6 100644
--- a/src/http_ana.c
+++ b/src/http_ana.c
@@ -2247,8 +2247,6 @@ int http_response_forward_body(struct stream *s, struct channel *res, int an_bit
 		health_adjust(__objt_server(s->target), HANA_STATUS_HTTP_RSP);
 	}
 	stream_inc_http_fail_ctr(s);
-	if (!(s->flags & SF_ERR_MASK))
-		s->flags |= SF_ERR_SRVCL;
 	/* fall through */
 
    return_error: