From: Nicholas Mc Guire Date: Mon, 2 Jul 2018 09:08:16 +0000 (+0200) Subject: powerpc/pseries: Fix missing of_node_put() in rng_init() X-Git-Tag: v5.10-rc1~105^2~216 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=67c3e59443f5fc77be39e2ce0db75fbfa78c7965;p=thirdparty%2Fkernel%2Flinux.git powerpc/pseries: Fix missing of_node_put() in rng_init() The call to of_find_compatible_node() returns a node pointer with refcount incremented thus it must be explicitly decremented here before returning. Fixes: a489043f4626 ("powerpc/pseries: Implement arch_get_random_long() based on H_RANDOM") Signed-off-by: Nicholas Mc Guire Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/1530522496-14816-1-git-send-email-hofrat@osadl.org --- diff --git a/arch/powerpc/platforms/pseries/rng.c b/arch/powerpc/platforms/pseries/rng.c index bbb97169bf63e..6268545947b83 100644 --- a/arch/powerpc/platforms/pseries/rng.c +++ b/arch/powerpc/platforms/pseries/rng.c @@ -36,6 +36,7 @@ static __init int rng_init(void) ppc_md.get_random_seed = pseries_get_random_long; + of_node_put(dn); return 0; } machine_subsys_initcall(pseries, rng_init);