From: Aki Tuomi <aki.tuomi@dovecot.fi>
Date: Mon, 27 Feb 2017 18:38:43 +0000 (+0200)
Subject: doveadm: Ensure -- is added to command line before positional arguments for non-mails... 
X-Git-Tag: 2.2.29.rc1~198
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=67c6ef1488a9fd1e87b5891665c700c122e50316;p=thirdparty%2Fdovecot%2Fcore.git

doveadm: Ensure -- is added to command line before positional arguments for non-mails commands as well

Was forgotten from 967efe37d1f10a28c0a086cc5919d4ce8917bed8
---

diff --git a/src/doveadm/doveadm-cmd.c b/src/doveadm/doveadm-cmd.c
index 62ca39bda9..627856dcf4 100644
--- a/src/doveadm/doveadm-cmd.c
+++ b/src/doveadm/doveadm-cmd.c
@@ -321,6 +321,10 @@ doveadm_cmd_params_to_argv(const char *name, int pargc, const struct doveadm_cmd
 	const char * const * cptr;
 	i_assert(array_count(argv) == 0);
 	array_append(argv, &name, 1);
+
+	ARRAY_TYPE(const_string) pargv;
+	t_array_init(&pargv, 8);
+
 	for(i=0;i<pargc;i++) {
 		const char *optarg = NULL;
 		/* istreams are special */
@@ -349,11 +353,20 @@ doveadm_cmd_params_to_argv(const char *name, int pargc, const struct doveadm_cmd
 				array_foreach(&params[i].value.v_array, cptr) {
 					if (array_add_opt)
 						array_append(argv, &optarg, 1);
-					array_append(argv, cptr, 1);
+					if ((params[i].flags & CMD_PARAM_FLAG_POSITIONAL) == 0)
+						array_append(argv, cptr, 1);
+					else
+						array_append(&pargv, cptr, 1);
 				}
 			}
 		}
 	}
+
+	if (array_count(&pargv) > 0) {
+		const char *dashdash = "--";
+		array_append(argv, &dashdash, 1);
+		array_append_array(argv, &pargv);
+	}
 	array_append_zero(argv);
 }