From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 21 May 2021 14:06:37 +0000 (+0300)
Subject: lib-lua: dlua_script_init() - Always return -1 if script_init() fails
X-Git-Tag: 2.3.16~73
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=67c7c1aaae6d64108ce9925a18b9fff2f206483e;p=thirdparty%2Fdovecot%2Fcore.git

lib-lua: dlua_script_init() - Always return -1 if script_init() fails

The previous behavior was to forward the script_init() return value to
the caller. This was somewhat unexpected behavior.
---

diff --git a/src/lib-lua/dlua-script.c b/src/lib-lua/dlua-script.c
index 822eb0ca83..a0c5d4ef2e 100644
--- a/src/lib-lua/dlua-script.c
+++ b/src/lib-lua/dlua-script.c
@@ -173,8 +173,10 @@ int dlua_script_init(struct dlua_script *script, const char **error_r)
 
 	if (lua_isinteger(script->L, -1)) {
 		ret = lua_tointeger(script->L, -1);
-		if (ret != 0)
+		if (ret != 0) {
 			*error_r = "Script init failed";
+			ret = -1;
+		}
 	} else {
 		*error_r = LUA_SCRIPT_INIT_FN"() returned non-number";
 		ret = -1;