From: Colin Ian King Date: Thu, 22 Aug 2019 01:03:50 +0000 (+0200) Subject: bus: moxtet: fix unsigned comparison to less than zero X-Git-Tag: v5.4-rc1~186^2~14 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6811d26df50d96635dd339cf8cdf43a6abc0c4b6;p=thirdparty%2Flinux.git bus: moxtet: fix unsigned comparison to less than zero Currently the size_t variable res is being checked for an error failure however the unsigned variable is never less than zero so this test is always false. Fix this by making variable res ssize_t Link: https://lore.kernel.org/r/20190822010351.15660-2-marek.behun@nic.cz Addresses-Coverity: ("Unsigned compared against 0") Fixes: 5bc7f990cd98 ("bus: Add support for Moxtet bus") Signed-off-by: Colin Ian King Signed-off-by: Marek Behún Signed-off-by: Arnd Bergmann --- diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c index baccf76093572..36cf13eee6b8b 100644 --- a/drivers/bus/moxtet.c +++ b/drivers/bus/moxtet.c @@ -514,7 +514,7 @@ static ssize_t output_write(struct file *file, const char __user *buf, struct moxtet *moxtet = file->private_data; u8 bin[TURRIS_MOX_MAX_MODULES]; u8 hex[sizeof(bin) * 2 + 1]; - size_t res; + ssize_t res; loff_t dummy = 0; int err, i;