From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Thu, 28 Jan 2021 15:50:40 +0000 (-0300)
Subject: pgbench: Remove dead code
X-Git-Tag: REL_14_BETA1~858
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6819b9042fe69154ff3fd2337c5028038d3cfab4;p=thirdparty%2Fpostgresql.git

pgbench: Remove dead code

doConnect() never returns connections in state CONNECTION_BAD, so
checking for that is pointless.  Remove the code that does.

This code has been dead since ba708ea3dc84, 20 years ago.

Discussion: https://postgr.es/m/20210126195224.GA20361@alvherre.pgsql
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
---

diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 1be1ad3d6d9..a4a3f40048e 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -6040,13 +6040,6 @@ main(int argc, char **argv)
 	if (con == NULL)
 		exit(1);
 
-	if (PQstatus(con) == CONNECTION_BAD)
-	{
-		pg_log_fatal("connection to database \"%s\" failed: %s",
-					 dbName, PQerrorMessage(con));
-		exit(1);
-	}
-
 	if (internal_script_used)
 		GetTableInfo(con, scale_given);