From: Peter Eisentraut <peter@eisentraut.org>
Date: Tue, 29 Aug 2023 06:58:56 +0000 (+0200)
Subject: Remove useless if condition
X-Git-Tag: REL_17_BETA1~1946
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6844d3275ac6b3c35d824f49362d3fe59b30f26b;p=thirdparty%2Fpostgresql.git

Remove useless if condition

We can call GetAttributeCompression() with a NULL argument.  It
handles that internally already.  This change makes all the callers of
GetAttributeCompression() uniform.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org
---

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 48f17a34039..d097da3c78e 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -944,11 +944,7 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
 
 		attr->attidentity = colDef->identity;
 		attr->attgenerated = colDef->generated;
-
-		if (colDef->compression)
-			attr->attcompression = GetAttributeCompression(attr->atttypid,
-														   colDef->compression);
-
+		attr->attcompression = GetAttributeCompression(attr->atttypid, colDef->compression);
 		if (colDef->storage_name)
 			attr->attstorage = GetAttributeStorage(attr->atttypid, colDef->storage_name);
 	}