From: Jeremy Allison <jra@samba.org>
Date: Wed, 29 Apr 2015 00:20:42 +0000 (-0700)
Subject: s4: Fix bad review I did in dom_sid_parse_length() code.
X-Git-Tag: tevent-0.9.25~650
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=688aae8bac975e5f0025e2e56dbde3a93634f59b;p=thirdparty%2Fsamba.git

s4: Fix bad review I did in dom_sid_parse_length() code.

Volker, apologies for the mistake.

Spotted by Andrew Bartlett <abartlet@samba.org>

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Apr 29 08:20:23 CEST 2015 on sn-devel-104
---

diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c
index 291043446b0..8b30ee67eea 100644
--- a/libcli/security/dom_sid.c
+++ b/libcli/security/dom_sid.c
@@ -244,7 +244,8 @@ struct dom_sid *dom_sid_parse_talloc(TALLOC_CTX *mem_ctx, const char *sidstr)
 struct dom_sid *dom_sid_parse_length(TALLOC_CTX *mem_ctx, const DATA_BLOB *sid)
 {
 	char p[sid->length+1];
-	memcpy(p, sid->data, sizeof(p));
+	memcpy(p, sid->data, sid->length);
+	p[sid->length] = '\0';
 	return dom_sid_parse_talloc(mem_ctx, p);
 }