From: Yang Yingliang <yangyingliang@huawei.com>
Date: Mon, 25 Oct 2021 05:00:55 +0000 (+0800)
Subject: irqchip/mchp-eic: Fix return value check in mchp_eic_init()
X-Git-Tag: v5.16-rc1~202^2^2~3^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=68a6e0c63c76128d403e8ca016c0bcb732ff1b05;p=thirdparty%2Fkernel%2Flinux.git

irqchip/mchp-eic: Fix return value check in mchp_eic_init()

In case of error, the function of_iomap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211025050055.1129845-1-yangyingliang@huawei.com
---

diff --git a/drivers/irqchip/irq-mchp-eic.c b/drivers/irqchip/irq-mchp-eic.c
index 09b7a8cdb6119..c726a19837d29 100644
--- a/drivers/irqchip/irq-mchp-eic.c
+++ b/drivers/irqchip/irq-mchp-eic.c
@@ -209,7 +209,7 @@ static int mchp_eic_init(struct device_node *node, struct device_node *parent)
 		return -ENOMEM;
 
 	eic->base = of_iomap(node, 0);
-	if (IS_ERR(eic->base)) {
+	if (!eic->base) {
 		ret = -ENOMEM;
 		goto free;
 	}