From: Tomas Mraz <tomas@openssl.org>
Date: Wed, 9 Aug 2023 13:10:10 +0000 (+0200)
Subject: Remove TODO(QUIC) about raising errors from ossl_quic_tls_tick()
X-Git-Tag: openssl-3.2.0-alpha1~179
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=68b9a32aa397030d9e49ee1ae84ca1ce6b58efd3;p=thirdparty%2Fopenssl.git

Remove TODO(QUIC) about raising errors from ossl_quic_tls_tick()

This was already resolved by https://github.com/openssl/openssl/pull/21547

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21700)
---

diff --git a/ssl/quic/quic_tls.c b/ssl/quic/quic_tls.c
index d043b8c2661..8f104f63e3f 100644
--- a/ssl/quic/quic_tls.c
+++ b/ssl/quic/quic_tls.c
@@ -700,13 +700,6 @@ int ossl_quic_tls_tick(QUIC_TLS *qtls)
     const unsigned char *alpn;
     unsigned int alpnlen;
 
-    /*
-     * TODO(QUIC): There are various calls here that could fail and ordinarily
-     * would result in an ERR_raise call - but "tick" calls aren't supposed to
-     * fail "loudly" - so its unclear how we will report these errors. The
-     * ERR_raise calls are omitted from this function for now.
-     */
-
     if (qtls->inerror)
         return 0;