From: Phil Sutter <phil@nwl.cc>
Date: Fri, 16 May 2025 17:41:19 +0000 (+0200)
Subject: netlink: Catch unknown types when deserializing objects
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=690f19eadde5cb607ec3d8d471c86d558c7229bd;p=thirdparty%2Fnftables.git

netlink: Catch unknown types when deserializing objects

Print an error message and discard the object instead of returning it to
the caller. At least when trying to print it, we would hit an assert()
in obj_type_name() anyway.

Fixes: 4756d92e517ae ("src: listing of stateful objects")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/src/netlink.c b/src/netlink.c
index 0724190a..52010c74 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -1802,6 +1802,10 @@ struct obj *netlink_delinearize_obj(struct netlink_ctx *ctx,
 		obj->synproxy.flags =
 			nftnl_obj_get_u32(nlo, NFTNL_OBJ_SYNPROXY_FLAGS);
 		break;
+	default:
+		netlink_io_error(ctx, NULL, "Unknown object type %u", type);
+		obj_free(obj);
+		return NULL;
 	}
 	obj->type = type;