From: Daniel Gustafsson <dgustafsson@postgresql.org>
Date: Fri, 8 Mar 2024 21:50:20 +0000 (+0100)
Subject: Replace perror with custom postgres logging
X-Git-Tag: REL_17_BETA1~704
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6929e133b309d5d4568b5ed25b136935f63be618;p=thirdparty%2Fpostgresql.git

Replace perror with custom postgres logging

perror() is not used in postgres anymore out of policy, this replaces
the final callsites with the custom postgres logging framework.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/89B00F63-40F7-4D82-8353-DC9CABBAC1D1@yesql.se
---

diff --git a/src/common/exec.c b/src/common/exec.c
index da929f15b95..bcd5b71101e 100644
--- a/src/common/exec.c
+++ b/src/common/exec.c
@@ -378,7 +378,8 @@ pipe_read_line(char *cmd)
 	errno = 0;
 	if ((pipe_cmd = popen(cmd, "r")) == NULL)
 	{
-		perror("popen failure");
+		log_error(errcode(ERRCODE_SYSTEM_ERROR),
+				  _("could not execute command \"%s\": %m"), cmd);
 		return NULL;
 	}