From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Oct 2015 20:36:00 +0000 (-0700)
Subject: transport-helper: read helper response with strbuf_getline()
X-Git-Tag: v2.8.0-rc0~85^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=692dfdfa622c6286999609a4fef59724124ca794;p=thirdparty%2Fgit.git

transport-helper: read helper response with strbuf_getline()

Our implementation of helpers never use CRLF line endings, and they
do not depend on the ability to place a CR as payload at the end of
the line, so this is essentially a no-op for in-tree users.  However,
this allows third-party implementation of helpers to give us their
line with CRLF line ending (they cannot expect us to feed CRLF to
them, though).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/transport-helper.c b/transport-helper.c
index e45d88f1d7..a6bff8b308 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -54,7 +54,7 @@ static int recvline_fh(FILE *helper, struct strbuf *buffer, const char *name)
 	strbuf_reset(buffer);
 	if (debug)
 		fprintf(stderr, "Debug: Remote helper: Waiting...\n");
-	if (strbuf_getline_lf(buffer, helper) == EOF) {
+	if (strbuf_getline(buffer, helper) == EOF) {
 		if (debug)
 			fprintf(stderr, "Debug: Remote helper quit.\n");
 		return 1;