From: Dan Carpenter Date: Fri, 23 Jun 2017 15:17:38 +0000 (+0300) Subject: libertas: Fix lbs_prb_rsp_limit_set() X-Git-Tag: v4.13-rc1~157^2~44^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=69551f5f370cc20342fab17ca54716b6ec7e332d;p=thirdparty%2Fkernel%2Flinux.git libertas: Fix lbs_prb_rsp_limit_set() The kstrtoul() test was reversed so this always returned -ENOTSUPP. Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()") Signed-off-by: Dan Carpenter Reviewed-by: James Cameron Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c index eeeb892219aa4..37ace5cb309d1 100644 --- a/drivers/net/wireless/marvell/libertas/mesh.c +++ b/drivers/net/wireless/marvell/libertas/mesh.c @@ -233,8 +233,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev, memset(&mesh_access, 0, sizeof(mesh_access)); mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET); - if (!kstrtoul(buf, 10, &retry_limit)) - return -ENOTSUPP; + ret = kstrtoul(buf, 10, &retry_limit); + if (ret) + return ret; if (retry_limit > 15) return -ENOTSUPP;