From: Noah Misch <noah@leadboat.com>
Date: Sun, 7 Jun 2020 23:27:13 +0000 (-0700)
Subject: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS.
X-Git-Tag: REL9_5_23~56
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=696cb6d8f6be667af79a512db57ab0bad3248f42;p=thirdparty%2Fpostgresql.git

MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS.

Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic
error, which had no functional implications, by adding "use warnings".
The buildfarm always customizes PROVE_FLAGS, so the warning did not
appear there.  Back-patch to 9.5 (all supported versions).
---

diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
index 1a9a282494f..2986a9053ab 100644
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -189,7 +189,7 @@ sub tap_check
 	  unless $config->{tap_tests};
 
 	my @flags;
-	foreach my $arg (0 .. scalar(@_))
+	foreach my $arg (0 .. scalar(@_) - 1)
 	{
 		next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;
 		@flags = split(/\s+/, $1);