From: Mark Wielaard <mark@klomp.org>
Date: Tue, 30 Apr 2019 18:36:39 +0000 (+0200)
Subject: tests: Don't printf a known NULL symname.
X-Git-Tag: elfutils-0.177~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6978871366465aac849a303b2ea05ff5ab602261;p=thirdparty%2Felfutils.git

tests: Don't printf a known NULL symname.

GCC9 on 32bit systems might warn about '%s' directive argument is null
for symname in backtrace.c. Just check whether symname is NULL.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---

diff --git a/tests/ChangeLog b/tests/ChangeLog
index 71aa178d3..a4f5dd3ed 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,7 @@
+2019-04-30  Mark Wielaard  <mark@klomp.org>
+
+	* backtrace.c (frame_callback): Explicitly check symname is NULL.
+
 2019-03-04  Mark Wielaard  <mark@klomp.org>
 
 	* backtrace.c (tgkill): Remove define.
diff --git a/tests/backtrace.c b/tests/backtrace.c
index ecf558306..36c8b8c45 100644
--- a/tests/backtrace.c
+++ b/tests/backtrace.c
@@ -185,7 +185,7 @@ frame_callback (Dwfl_Frame *state, void *frame_arg)
     symname = dwfl_module_addrname (mod, pc_adjusted);
 
   printf ("#%2d %#" PRIx64 "%4s\t%s\n", *framenop, (uint64_t) pc,
-	  ! isactivation ? "- 1" : "", symname);
+	  ! isactivation ? "- 1" : "", symname ?: "<null>");
   pid_t tid = dwfl_thread_tid (thread);
   callback_verify (tid, *framenop, pc, symname, dwfl);
   (*framenop)++;