From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 28 Jun 2025 15:07:54 +0000 (-0700)
Subject: od: fix another off-by-one issue with --strings
X-Git-Tag: v9.8~282
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=69b07cc58de0a86f7b06d6709049077c6bd486ea;p=thirdparty%2Fcoreutils.git

od: fix another off-by-one issue with --strings

* src/od.c (main): Fix off-by-one error in string_min limit.
---

diff --git a/src/od.c b/src/od.c
index 7306b0f9ad..439f71e5b5 100644
--- a/src/od.c
+++ b/src/od.c
@@ -1738,10 +1738,10 @@ main (int argc, char **argv)
               if (s_err != LONGINT_OK)
                 xstrtol_fatal (s_err, oi, c, long_options, optarg);
 
-              /* The minimum string length may be no larger than
+              /* The minimum string length must be less than
                  MIN (IDX_MAX, SIZE_MAX), since we may allocate a
-                 buffer of this size.  */
-              if (MIN (IDX_MAX, SIZE_MAX) < tmp)
+                 buffer of this size + 1.  */
+              if (MIN (IDX_MAX, SIZE_MAX) <= tmp)
                 error (EXIT_FAILURE, 0, _("%s is too large"), quote (optarg));
 
               string_min = tmp;