From: Phil Sutter <phil@nwl.cc>
Date: Fri, 12 Jul 2024 11:03:18 +0000 (+0200)
Subject: xtables-monitor: Flush stdout after all lines of output
X-Git-Tag: v1.8.11~55
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=69da16a7790048a176a44530eb57e4b60184ce6e;p=thirdparty%2Fiptables.git

xtables-monitor: Flush stdout after all lines of output

Writing an xtables-monitor testsuite is pretty much impossible without
this due to unreliable output flushing. Just move the fflush() call from
trace_cb() to its caller so monitor events benefit from it as well.

Fixes: 07af4da52ab30 ("xtables-monitor: fix rule printing")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/iptables/xtables-monitor.c b/iptables/xtables-monitor.c
index cf92355f..90d1cc5e 100644
--- a/iptables/xtables-monitor.c
+++ b/iptables/xtables-monitor.c
@@ -544,7 +544,6 @@ static int trace_cb(const struct nlmsghdr *nlh, struct cb_arg *arg)
 err_free:
 	nftnl_trace_free(nlt);
 err:
-	fflush(stdout);
 	return MNL_CB_OK;
 }
 
@@ -576,6 +575,7 @@ static int monitor_cb(const struct nlmsghdr *nlh, void *data)
 		break;
 	}
 
+	fflush(stdout);
 	return ret;
 }