From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 21 Jul 2022 10:58:44 +0000 (+0200)
Subject: qemuDomainBlockResize: Always refuse resize of empty/readonly disks
X-Git-Tag: v8.7.0-rc1~88
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=69e3a317292050383f021946609d6183ca208d9a;p=thirdparty%2Flibvirt.git

qemuDomainBlockResize: Always refuse resize of empty/readonly disks

The operation makes no sense regardless of the way how we specify disks.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e7820e1fb2..944f3ecde7 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9954,14 +9954,15 @@ qemuDomainBlockResize(virDomainPtr dom,
         disk->src->format == VIR_STORAGE_FILE_QED)
         size = VIR_ROUND_UP(size, 512);
 
+    if (virStorageSourceIsEmpty(disk->src) || disk->src->readonly) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
+                       _("can't resize empty or readonly disk '%s'"),
+                       disk->dst);
+        goto endjob;
+    }
+
     if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV) &&
         !qemuDiskBusIsSD(disk->bus)) {
-        if (virStorageSourceIsEmpty(disk->src) || disk->src->readonly) {
-            virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
-                           _("can't resize empty or readonly disk '%s'"),
-                           disk->dst);
-            goto endjob;
-        }
 
         nodename = disk->src->nodeformat;
     } else {