From: Hendrik Donner <hd@os-cillation.de>
Date: Thu, 6 Mar 2025 20:15:39 +0000 (+0100)
Subject: checkpatch.pl: Report an error for CONFIG_xPL_BUILD in device trees
X-Git-Tag: v2025.04-rc5~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=69fb899133b6c374eff11b13482371bec6898a01;p=thirdparty%2Fu-boot.git

checkpatch.pl: Report an error for CONFIG_xPL_BUILD in device trees

The defines for the different build phases shouldn't be used in device
trees, currently they aren't even defined for device tree pre processing,
resulting in build errors.

Link: https://lists.denx.de/pipermail/u-boot/2025-March/582787.html
Signed-off-by: Hendrik Donner <hd@os-cillation.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f9f8891c0c4..414019c5b89 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2692,6 +2692,12 @@ sub u_boot_line {
 		ERROR("PRE_SCHEMA",
 		      "Driver model schema uses 'bootph-...' tags now\n" . $herecurr);
 	}
+
+	# Do not allow CONFIG_xPL_BUILD in device trees
+	if ($realfile =~ /\.dtsi?$/ && $line =~ /^\+.*CONFIG_(X|S|T|V)PL_BUILD.*/) {
+		ERROR("CONFIG_xPL_BUILD",
+		      "Do not use CONFIG_xPL_BUILD in device trees\n" . $herecurr);
+	}
 }
 
 sub exclude_global_initialisers {