From: Karel Zak <kzak@redhat.com>
Date: Tue, 18 Feb 2025 09:37:28 +0000 (+0100)
Subject: findmnt: fix resource leaks [coverity scan]
X-Git-Tag: v2.42-start~43
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6a14329c6d24c7f29e525fcd1464d535c48b80d8;p=thirdparty%2Futil-linux.git

findmnt: fix resource leaks [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/misc-utils/findmnt.c b/misc-utils/findmnt.c
index a497ceeca..fbfb84c94 100644
--- a/misc-utils/findmnt.c
+++ b/misc-utils/findmnt.c
@@ -1087,31 +1087,33 @@ static struct libmnt_table *parse_tabfiles(char **files,
 
 static struct libmnt_table *fetch_listmount(void)
 {
-	struct libmnt_table *tb;
-	struct libmnt_statmnt *sm;
+	struct libmnt_table *tb = NULL;
+	struct libmnt_statmnt *sm = NULL;
 
 	sm = mnt_new_statmnt();
 	if (!sm) {
 		warn(_("failed to allocate statmnt handler"));
-		return NULL;
+		goto failed;
 	}
 
 	tb = mnt_new_table();
 	if (!tb) {
 		warn(_("failed to initialize libmount table"));
-		return NULL;
+		goto failed;
 	}
 
 	mnt_table_refer_statmnt(tb, sm);
 
 	if (mnt_table_fetch_listmount(tb) != 0) {
 		warn(_("failed to fetch mount nodes"));
-		mnt_unref_table(tb);
-		mnt_unref_statmnt(sm);
-		return NULL;
+		goto failed;
 	}
 
 	return tb;
+failed:
+	mnt_unref_table(tb);
+	mnt_unref_statmnt(sm);
+	return NULL;
 }
 
 /*