From: stephan <stephan@noemail.net>
Date: Sat, 26 Aug 2023 18:15:33 +0000 (+0000)
Subject: Remove a bunch of commented-out debug output.
X-Git-Tag: version-3.44.0~275
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6a1ebbdb909a973b431ca088a7e386b2508fbe8a;p=thirdparty%2Fsqlite.git

Remove a bunch of commented-out debug output.

FossilOrigin-Name: b49488481e2952294960bb0ee971f6eca126c19d68ef92152894aa28393e6865
---

diff --git a/ext/jni/src/c/sqlite3-jni.c b/ext/jni/src/c/sqlite3-jni.c
index a056b0b534..93cb975af7 100644
--- a/ext/jni/src/c/sqlite3-jni.c
+++ b/ext/jni/src/c/sqlite3-jni.c
@@ -635,44 +635,36 @@ static void s3jni_incr( volatile unsigned int * const p ){
 
 #define S3JniMutex_Env_enter                        \
   S3JniMutex_Env_assertNotLocker;                   \
-  /*MARKER(("Entering ENV mutex@%p %s.\n", env));*/ \
   sqlite3_mutex_enter( SJG.envCache.mutex );        \
   s3jni_incr(&SJG.metrics.nMutexEnv);               \
   SJG.envCache.locker = env
 #define S3JniMutex_Env_leave                         \
-  /*MARKER(("Leaving ENV mutex @%p %s.\n", env));*/  \
   S3JniMutex_Env_assertLocker;                       \
   SJG.envCache.locker = 0;                           \
   sqlite3_mutex_leave( SJG.envCache.mutex )
 
 #define S3JniMutex_Ext_enter                            \
-  /*MARKER(("Entering autoExt mutex@%p %s.\n", env));*/ \
   sqlite3_mutex_enter( SJG.autoExt.mutex );             \
   SJG.autoExt.locker = env;                             \
   s3jni_incr( &SJG.metrics.nMutexAutoExt )
 #define S3JniMutex_Ext_leave                            \
-  /*MARKER(("Leaving autoExt mutex@%p %s.\n", env));*/  \
   assert( env == SJG.autoExt.locker );                  \
   sqlite3_mutex_leave( SJG.autoExt.mutex )
 #define S3JniMutex_Ext_assertLocker                     \
   assert( env == SJG.autoExt.locker )
 
 #define S3JniMutex_Global_enter                        \
-  /*MARKER(("Entering GLOBAL mutex@%p %s.\n", env));*/ \
   sqlite3_mutex_enter( SJG.mutex );                    \
   s3jni_incr(&SJG.metrics.nMutexGlobal);
 #define S3JniMutex_Global_leave                         \
-  /*MARKER(("Leaving GLOBAL mutex @%p %s.\n", env));*/  \
   sqlite3_mutex_leave( SJG.mutex )
 
 #define S3JniMutex_Nph_enter                        \
   S3JniMutex_Env_assertNotLocker;                   \
-  /*MARKER(("Entering NPH mutex@%p %s.\n", env));*/ \
   sqlite3_mutex_enter( SJG.envCache.mutex );        \
   s3jni_incr( &SJG.metrics.nMutexEnv2 );            \
   SJG.envCache.locker = env
 #define S3JniMutex_Nph_leave                         \
-  /*MARKER(("Leaving NPH mutex @%p %s.\n", env));*/  \
   S3JniMutex_Env_assertLocker;                       \
   SJG.envCache.locker = 0;                           \
   sqlite3_mutex_leave( SJG.envCache.mutex )
@@ -683,7 +675,6 @@ static void s3jni_incr( volatile unsigned int * const p ){
   s3jni_incr( &SJG.metrics.nMutexPerDb );             \
   SJG.perDb.locker = env;
 #define S3JniMutex_S3JniDb_leave                      \
-  /*MARKER(("Leaving PerDb mutex@%p %s.\n", env));*/  \
   assert( env == SJG.perDb.locker );                  \
   SJG.perDb.locker = 0;                               \
   sqlite3_mutex_leave( SJG.perDb.mutex )
@@ -1635,7 +1626,6 @@ static S3JniUdf * S3JniUdf_alloc(JNIEnv * const env, jobject jObj){
 
 static void S3JniUdf_free(S3JniUdf * s){
   S3JniDeclLocal_env;
-  //MARKER(("UDF cleanup: %s\n", s->zFuncName));
   s3jni_call_xDestroy(env, s->jObj);
   S3JniUnrefGlobal(s->jObj);
   sqlite3_free(s->zFuncName);
@@ -1648,7 +1638,6 @@ static void S3JniUdf_free(S3JniUdf * s){
 }
 
 static void S3JniUdf_finalizer(void * s){
-  //MARKER(("UDF finalizer @ %p\n", s));
   S3JniUdf_free((S3JniUdf*)s);
 }
 
@@ -1754,7 +1743,6 @@ static int udf_xFSI(sqlite3_context* const pCx, int argc,
   udf_jargs args = {0,0};
   int rc = udf_args(env, pCx, argc, argv, &args.jcx, &args.jargv);
 
-  //MARKER(("UDF::%s.%s()\n", s->zFuncName, zFuncType));
   if( 0 == rc ){
     (*env)->CallVoidMethod(env, s->jObj, xMethodID, args.jcx, args.jargv);
     S3JniIfThrew{
@@ -1778,12 +1766,10 @@ static int udf_xFV(sqlite3_context* cx, S3JniUdf * s,
   jobject jcx = new_sqlite3_context_wrapper(env, cx);
   int rc = 0;
   int const isFinal = 'F'==zFuncType[1]/*xFinal*/;
-  //MARKER(("%s.%s() cx = %p\n", s->zFuncName, zFuncType, cx));
   if( !jcx ){
     if( isFinal ) sqlite3_result_error_nomem(cx);
     return SQLITE_NOMEM;
   }
-  //MARKER(("UDF::%s.%s()\n", s->zFuncName, zFuncType));
   (*env)->CallVoidMethod(env, s->jObj, xMethodID, jcx);
   S3JniIfThrew{
     rc = udf_report_exception(env, isFinal, cx, s->zFuncName,
@@ -3104,11 +3090,6 @@ end:
     S3JniUnrefLocal(jStmt);
     jStmt = 0;
   }
-#if 0
-  if( 0!=rc ){
-    MARKER(("prepare rc = %d\n", rc));
-  }
-#endif
   OutputPointer_set_sqlite3_stmt(env, jOutStmt, jStmt);
   return (jint)rc;
 }
@@ -3840,7 +3821,6 @@ static int s3jni_trace_impl(unsigned traceflag, void *pC, void *pP, void *pX){
     case SQLITE_TRACE_STMT:
       jX = s3jni_utf8_to_jstring(env, (const char *)pX, -1);
       if( !jX ) rc = SQLITE_NOMEM;
-      /*MARKER(("TRACE_STMT@%p SQL=%p / %s\n", pP, jX, (const char *)pX));*/
       break;
     case SQLITE_TRACE_PROFILE:
       jX = (*env)->NewObject(env, SJG.g.cLong, SJG.g.ctorLong1,
diff --git a/manifest b/manifest
index 99091cafcc..69941ee6c3 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Re-order\ssome\sout-of-order\sJNI\sAPIs.\sCorrect\sJNI\ssqlite3_open_v2()\sbehavior\sin\sa\sparticular\sOOM\scondition.
-D 2023-08-26T18:01:36.744
+C Remove\sa\sbunch\sof\scommented-out\sdebug\soutput.
+D 2023-08-26T18:15:33.351
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -236,7 +236,7 @@ F ext/icu/sqliteicu.h fa373836ed5a1ee7478bdf8a1650689294e41d0c89c1daab26e9ae78a3
 F ext/jni/GNUmakefile d9244b5addf58868343a74a94faa71f829e7f40c163486d053f4b4bbea173703
 F ext/jni/README.md 1332b1fa27918bd5d9ca2d0d4f3ac3a6ab86b9e3699dc5bfe32904a027f3d2a9
 F ext/jni/jar-dist.make 030aaa4ae71dd86e4ec5e7c1e6cd86f9dfa47c4592c070d2e35157e42498e1fa
-F ext/jni/src/c/sqlite3-jni.c 2bbd0443b336a9c4d4cfea37a254592c96cf95f18f5aad0c60ff45968311bb61
+F ext/jni/src/c/sqlite3-jni.c 5ccdea9487e66f0850aaa817ffe8523a84c4376235ae967c3700513665c0883a
 F ext/jni/src/c/sqlite3-jni.h 22c6c760a31ebfc3fe13d45d2a3a4dd7c8f9c6207aeba3fdc38137452cbf3a04
 F ext/jni/src/org/sqlite/jni/AggregateFunction.java e0aac6ccae05702f8ee779820570866a2760aaa57a73135c57c8d3580bef52d5
 F ext/jni/src/org/sqlite/jni/AuthorizerCallback.java c374bb76409cce7a0bdba94877706b59ac6127fa5d9e6af3e8058c99ce99c030
@@ -2103,8 +2103,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 6a6ee6dd54ec1a1dc7fb7d2f331951525d394a8362aef911f62878ac3961898f
-R 802391c6b76d7ea843bfc8720b7feccc
+P 49d3be002ce5e594027f47a3ba448f0c21ec68b416b8df997497753f53e3ca52
+R a3f75122b9068beff86867201ce6d194
 U stephan
-Z 04c34431ca2b1ac34ae8b832852ca4c0
+Z 6e844ab70f4837c2de7f262b42dd7747
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index 8dd2e2bd90..ea4bb054c3 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-49d3be002ce5e594027f47a3ba448f0c21ec68b416b8df997497753f53e3ca52
\ No newline at end of file
+b49488481e2952294960bb0ee971f6eca126c19d68ef92152894aa28393e6865
\ No newline at end of file