From: Gervase Markham <gerv@gerv.net>
Date: Wed, 11 Apr 2012 08:37:07 +0000 (+0100)
Subject: Bug 706412 - make JobQueue.pm support insertion of Job objects, and also enable prior... 
X-Git-Tag: bugzilla-4.3.1~30
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6a83a1dd95d39a9a438ed105daf29c3f42218435;p=thirdparty%2Fbugzilla.git

Bug 706412 - make JobQueue.pm support insertion of Job objects, and also enable prioritization. r,a=LpSolit.
---

diff --git a/Bugzilla/JobQueue.pm b/Bugzilla/JobQueue.pm
index ceea538095..f8bd6a615e 100644
--- a/Bugzilla/JobQueue.pm
+++ b/Bugzilla/JobQueue.pm
@@ -53,6 +53,7 @@ sub new {
             prefix => 'ts_',
         }],
         driver_cache_expiration => DRIVER_CACHE_TIME,
+        prioritize => 1,
     );
 
     return $self;
@@ -70,12 +71,19 @@ sub insert {
     my $self = shift;
     my $job = shift;
 
-    my $mapped_job = Bugzilla::JobQueue->job_map()->{$job};
-    ThrowCodeError('jobqueue_no_job_mapping', { job => $job })
-        if !$mapped_job;
-    unshift(@_, $mapped_job);
+    if (!ref($job)) {
+        my $mapped_job = Bugzilla::JobQueue->job_map()->{$job};
+        ThrowCodeError('jobqueue_no_job_mapping', { job => $job })
+            if !$mapped_job;
 
-    my $retval = $self->SUPER::insert(@_);
+        $job = new TheSchwartz::Job(
+            funcname => $mapped_job,
+            arg      => $_[0],
+            priority => $_[1] || 5
+        );
+    }
+    
+    my $retval = $self->SUPER::insert($job);
     # XXX Need to get an error message here if insert fails, but
     # I don't see any way to do that in TheSchwartz.
     ThrowCodeError('jobqueue_insert_failed', { job => $job, errmsg => $@ })