From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 23 May 2024 13:41:16 +0000 (+0200)
Subject: bash-completion: Run virsh/virt-admin in quiet mode
X-Git-Tag: v10.4.0-rc1~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6aa94ce10541eb3340d4a2d80343688751a0c669;p=thirdparty%2Flibvirt.git

bash-completion: Run virsh/virt-admin in quiet mode

In some cases (e.g. when virt-admin connects to the default URI)
some info message is printed onto stdout (using vshPrintExtra()).
This hurts user experience, just consider:

  virt-admin<TAB><TAB>
  NOTE\:\ Connecting\ to\ default\ daemon.\ Specify\ daemon\ using\ -c\ \(e.g.\ virtqemud\:///system\)

when no daemon is running. Suppress extra prints by passing '-q'
in the bash-completion script.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/tools/bash-completion/vsh.in b/tools/bash-completion/vsh.in
index 897f74cc08..5692788d63 100644
--- a/tools/bash-completion/vsh.in
+++ b/tools/bash-completion/vsh.in
@@ -30,7 +30,7 @@ _@command@_complete()
         c=$((++c))
     done
 
-    CMDLINE=( )
+    CMDLINE=( "-q" )
     if [ -n "${RO}" ]; then
         CMDLINE+=("-r")
     fi