From: Tuguoyi <tu.guoyi@h3c.com>
Date: Mon, 2 Nov 2020 09:04:57 +0000 (+0000)
Subject: qemu-img convert: Free @sn_opts in all error cases
X-Git-Tag: v5.2.0-rc0~2^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6aec830e77a3f80952b41e421dc23c0041c1e399;p=thirdparty%2Fqemu.git

qemu-img convert: Free @sn_opts in all error cases

@sn_opts is initialized at the beginning, so it should be deleted
after jumping to the lable 'fail_getopt'

Signed-off-by: Guoyi Tu <tu.guoyi@h3c.com>
Message-Id: <6ff1c5d372944494be3932274f75485d@h3c.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/qemu-img.c b/qemu-img.c
index a968c74cba3..c2c56fc797f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -2751,7 +2751,6 @@ out:
     qemu_progress_end();
     qemu_opts_del(opts);
     qemu_opts_free(create_opts);
-    qemu_opts_del(sn_opts);
     qobject_unref(open_opts);
     blk_unref(s.target);
     if (s.src) {
@@ -2763,6 +2762,7 @@ out:
     g_free(s.src_sectors);
     g_free(s.src_alignment);
 fail_getopt:
+    qemu_opts_del(sn_opts);
     g_free(options);
 
     return !!ret;