From: pcarana <pc.moreno2099@gmail.com>
Date: Tue, 14 Jan 2020 21:55:34 +0000 (-0600)
Subject: Fix memory leak when access methods error'd
X-Git-Tag: v1.2.0~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6af924e19fd55d3065f5deba0c226061e37e1238;p=thirdparty%2FFORT-validator.git

Fix memory leak when access methods error'd
---

diff --git a/src/object/certificate.c b/src/object/certificate.c
index bff0d2ad..5def8cab 100644
--- a/src/object/certificate.c
+++ b/src/object/certificate.c
@@ -2078,7 +2078,7 @@ certificate_traverse(struct rpp *rpp_parent, struct rpki_uri *cert_uri)
 		error = use_access_method(&sia_uris, exec_rsync_method,
 		    exec_rrdp_method);
 		if (error)
-			return error;
+			goto revert_uris;
 		break;
 	case CA:
 		if (!db_rrdp_uris_visited_exists(
@@ -2087,7 +2087,7 @@ certificate_traverse(struct rpp *rpp_parent, struct rpki_uri *cert_uri)
 			error = use_access_method(&sia_uris, exec_rsync_method,
 			    exec_rrdp_method);
 			if (error)
-				return error;
+				goto revert_uris;
 		} else {
 			mft_exists = true;
 		}