From: Amit Kapila Date: Tue, 23 Aug 2022 03:09:31 +0000 (+0530) Subject: Add CHECK_FOR_INTERRUPTS while decoding changes. X-Git-Tag: REL_10_23~63 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6b50433e865e58a686fed3cc17712d55407e63a5;p=thirdparty%2Fpostgresql.git Add CHECK_FOR_INTERRUPTS while decoding changes. While decoding changes in a loop, if we skip all the changes there is no CFI making the loop uninterruptible. Reported-by: Whale Song and Andrey Borodin Bug: 17580 Author: Masahiko Sawada Reviwed-by: Amit Kapila Backpatch-through: 10 Discussion: https://postgr.es/m/17580-849c1d5b6d7eb422@postgresql.org Discussion: https://postgr.es/m/B319ECD6-9A28-4CDF-A8F4-3591E0BF2369@yandex-team.ru --- diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 061555652c6..a65ec84a690 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -1525,6 +1525,8 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid, Relation relation = NULL; Oid reloid; + CHECK_FOR_INTERRUPTS(); + switch (change->action) { case REORDER_BUFFER_CHANGE_INTERNAL_SPEC_CONFIRM: