From: Lidong Chen <lidong.chen@oracle.com>
Date: Thu, 27 Mar 2025 17:56:35 +0000 (+0000)
Subject: loader/xnu: Fix memory leak
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6b64f297e5906feb295dcc6fb5046368f5f3e95b;p=thirdparty%2Fgrub.git

loader/xnu: Fix memory leak

In grub_xnu_load_kext_from_dir(), when the call to grub_device_open()
failed, it simply cleaned up previously allocated memory and returned
GRUB_ERR_NONE. However, it neglected to free ctx->newdirname which is
allocated before the call to grub_device_open().

Fixes: CID 473859

Signed-off-by: Lidong Chen <lidong.chen@oracle.com>
Reviewed-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
---

diff --git a/grub-core/loader/xnu.c b/grub-core/loader/xnu.c
index 4cca55df9..80831386e 100644
--- a/grub-core/loader/xnu.c
+++ b/grub-core/loader/xnu.c
@@ -1258,6 +1258,7 @@ grub_xnu_load_kext_from_dir (char *dirname, const char *osbundlerequired,
       grub_device_close (dev);
     }
   grub_free (device_name);
+  grub_free (ctx.newdirname);
 
   return GRUB_ERR_NONE;
 }