From: Markus Valentin <markus.valentin@open-xchange.com>
Date: Wed, 2 Feb 2022 15:58:24 +0000 (+0100)
Subject: imapc: imapc_sync_handle_untagged_fetches() - Commit after adding the untagged fetch... 
X-Git-Tag: 2.3.19~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6b7a40bd5d5f1df08b91e0ffb059506ac1dd682b;p=thirdparty%2Fdovecot%2Fcore.git

imapc: imapc_sync_handle_untagged_fetches() - Commit after adding the untagged fetch messages

The absence of the commit could have caused issues when
imapc_sync_finish() was not called as it left mbox->delayed_sync_trans
initialized but mbox->delayed_sync_view was NULL.

Broken by 55a8c2d294bb2f764209c7ce455d258b2b7506f5
---

diff --git a/src/lib-storage/index/imapc/imapc-sync.c b/src/lib-storage/index/imapc/imapc-sync.c
index afd8c67497..d99a00cfaa 100644
--- a/src/lib-storage/index/imapc/imapc-sync.c
+++ b/src/lib-storage/index/imapc/imapc-sync.c
@@ -583,6 +583,8 @@ static void imapc_sync_handle_untagged_fetches(struct imapc_mailbox *mbox)
 	}
 
 	mail_index_view_close(&updated_view);
+	if (mail_index_transaction_commit(&mbox->delayed_sync_trans) < 0)
+		mailbox_set_index_error(&mbox->box);
 	array_clear(&mbox->untagged_fetch_contexts);
 }