From: Yang Yingliang Date: Fri, 28 Jul 2023 08:51:20 +0000 (+0800) Subject: usb: gadget: midi2: fix missing unlock in f_midi2_block_opts_create() X-Git-Tag: v6.6-rc1~103^2~83 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6bb75eb9ff3acfc3e1f31c01d70e72b3b3637167;p=thirdparty%2Fkernel%2Flinux.git usb: gadget: midi2: fix missing unlock in f_midi2_block_opts_create() In the error path in f_midi2_block_opts_create(), mutex_unlock() is missed, fix it by move the unlock after 'out' label. Fixes: 29ee7a4dddd5 ("usb: gadget: midi2: Add configfs support") Signed-off-by: Yang Yingliang Reviewed-by: Takashi Iwai Link: https://lore.kernel.org/r/20230728085120.3192474-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/gadget/function/f_midi2.c b/drivers/usb/gadget/function/f_midi2.c index f1c47753e0c1f..5a971ba600fec 100644 --- a/drivers/usb/gadget/function/f_midi2.c +++ b/drivers/usb/gadget/function/f_midi2.c @@ -2350,8 +2350,8 @@ static int f_midi2_block_opts_create(struct f_midi2_ep_opts *ep_opts, ep_opts->blks[blk] = block_opts; *block_p = block_opts; - mutex_unlock(&ep_opts->opts->lock); out: + mutex_unlock(&ep_opts->opts->lock); return ret; }