From: Pauli <pauli@openssl.org>
Date: Thu, 28 Sep 2023 01:47:35 +0000 (+1000)
Subject: Coverity 1545175: use after free
X-Git-Tag: openssl-3.2.0-beta1~162
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6bd07949e54f9958eb8a0f9a597ceb3910753ab0;p=thirdparty%2Fopenssl.git

Coverity 1545175: use after free

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/22211)
---

diff --git a/crypto/rand/rand_lib.c b/crypto/rand/rand_lib.c
index 7fbbb0275b0..14999540abc 100644
--- a/crypto/rand/rand_lib.c
+++ b/crypto/rand/rand_lib.c
@@ -609,7 +609,6 @@ static EVP_RAND_CTX *rand_new_seed(OSSL_LIB_CTX *libctx)
     }
     if (!EVP_RAND_instantiate(ctx, 0, 0, NULL, 0, NULL)) {
         ERR_raise(ERR_LIB_RAND, RAND_R_ERROR_INSTANTIATING_DRBG);
-        EVP_RAND_CTX_free(ctx);
         goto err;
     }
     OPENSSL_free(props);