From: Andy Shevchenko Date: Mon, 21 Oct 2024 13:34:29 +0000 (+0300) Subject: platform/x86: intel_scu_ipc: Unify the flow in pwr_reg_rdwr() X-Git-Tag: v6.13-rc1~147^2~60 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6bd35252102e2b79acb54c74527c81c09f690759;p=thirdparty%2Fkernel%2Flinux.git platform/x86: intel_scu_ipc: Unify the flow in pwr_reg_rdwr() Unify the flow in pwr_reg_rdwr() with intel_scu_ipc_dev_command_with_size(). While read buffer is not currently being used by the callers of pwr_reg_rdwr(), this might change in the future. For the existing code it's a harmless change because the read data for the write operation is simply discarded. Tested-by: Ferry Toth Acked-by: Mika Westerberg Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20241021133705.2933464-2-andriy.shevchenko@linux.intel.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen --- diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c index 5b16d29c93d7d..8d11d18701a4f 100644 --- a/drivers/platform/x86/intel_scu_ipc.c +++ b/drivers/platform/x86/intel_scu_ipc.c @@ -325,7 +325,7 @@ static int pwr_reg_rdwr(struct intel_scu_ipc_dev *scu, u16 *addr, u8 *data, } err = intel_scu_ipc_check_status(scu); - if (!err && id == IPC_CMD_PCNTRL_R) { /* Read rbuf */ + if (!err) { /* Read rbuf */ /* Workaround: values are read as 0 without memcpy_fromio */ memcpy_fromio(cbuf, scu->ipc_base + 0x90, 16); for (nc = 0; nc < count; nc++)